-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): introduce status_kind
in the Context
#133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loyd
reviewed
Jul 16, 2024
loyd
reviewed
Jul 16, 2024
loyd
reviewed
Jul 16, 2024
Add a record into |
nerodono
force-pushed
the
feat/status_kind-in-context
branch
from
July 16, 2024 16:48
2f7bbc8
to
fdd3470
Compare
loyd
reviewed
Jul 17, 2024
loyd
reviewed
Jul 17, 2024
loyd
reviewed
Jul 17, 2024
loyd
reviewed
Jul 17, 2024
loyd
reviewed
Jul 17, 2024
loyd
reviewed
Jul 17, 2024
…le (`actor_status.rs`), fix comments and style
One moment, seems like I need to fix up more |
loyd
reviewed
Jul 17, 2024
loyd
approved these changes
Jul 17, 2024
nerodono
force-pushed
the
feat/status_kind-in-context
branch
from
July 17, 2024 13:55
b1775b0
to
de165a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user has special logic for, say, termination (i.e. waiting for some other actors to finish), it has to keep track of status as the internal state:
This can cause bugs that are difficult to catch (forgetting about the terminating flag when updating the state). Instead, we can provide some API to read actor's status, so user is not obligated with keeping
status
-related information in the internal state.